Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md sample code #38

Merged
merged 3 commits into from
Mar 29, 2015
Merged

Conversation

martinezdelariva
Copy link
Contributor

No description provided.

@weierophinney
Copy link
Contributor

This can be improved more: call getPath() on the URI instance, instead of using parse_url(). Care to make those changes as well?

@weierophinney weierophinney merged commit e17781d into phly:master Mar 29, 2015
weierophinney added a commit that referenced this pull request Mar 29, 2015
Updated README.md sample code
weierophinney added a commit that referenced this pull request Mar 29, 2015
weierophinney added a commit that referenced this pull request Mar 29, 2015
@weierophinney weierophinney added this to the 0.14.1 milestone Mar 29, 2015
@weierophinney
Copy link
Contributor

UPDATE: for 0.15.0, which will provide support for the latest revision of PSR-7, I've removed both of these test cases (as well as one other). Since PSR-7 now supports bare/empty paths, the assumptions are no longer correct.

In #39, I've provided a grid of various scenarios, covering:

  • empty path
  • root path
  • bare path
  • path with prefix slash
  • path with trailing slash
  • path with both prefix and trailing slash

and I also tested variants when nesting middleware; each has tests showing matches with and without a trailing slash.

@martinezdelariva
Copy link
Contributor Author

Ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants