Fix #27 #28
Merged
Fix #27 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the uri have the slash, the next request should also have the slash
- Refactored `Next::__invoke()` logic to push argument parsing to another
method, and thus simplify `__invoke()` to make understanding the code paths
easier.
- Identified the potential areas where trailing slash was still a problem:
- path of current request can have a slash, while the removed portion did not;
these needed separate comparisons.
- stripping the route from the path only needed to happen if it wasn't empty
and not '/'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #27 provides a test that shows another case when trailing slashes are not
handled correctly. The primary fix for this issue comes from phly/http#23, but
this patch also provides a few semantic changes that should ensure all cases
are handled correctly going forward.