[#25] Fix path reset on return from nested middleware #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a failure test where / is appended once it move to next middleware
- Also modified to pull body from resulting response instead of the one composed in the test case.
Added another test case to test for the inverse condition -- that a trailing slash **is** present if it was present in the original route. The fix requires ensuring that the original route is retained, but that matching is done without trailing slashes. At the same time, the original route must be retained so that the path is reset correctly -- without double slashes.
|
Included in 0.10.1. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch for #25. It updates the test suite to test for both:
and ensure that: