Support HTML ids which contain periods (#359)

Closes #352 Co-authored-by: Hugo Hache <hugo.hache@spaceable.org>
philss · Oct 6, 2021 · 5240128 · 5240128
1 parent ec056fb
commit 5240128
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/lib/floki/selector/parser.ex b/lib/floki/selector/parser.ex
@@ -54,7 +54,7 @@ defmodule Floki.Selector.Parser do
   end
 
   defp do_parse([{:hash, _, id} | t], selector) do
-    do_parse(t, %{selector | id: to_string(id)})
+    do_parse(t, %{selector | id: to_string(id) |> String.replace("\\.", ".")})
   end
 
   defp do_parse([{:class, _, class} | t], selector) do

diff --git a/src/floki_selector_lexer.xrl b/src/floki_selector_lexer.xrl
@@ -1,6 +1,6 @@
 Definitions.
 
-IDENTIFIER = [-A-Za-z0-9_]+
+IDENTIFIER = [-A-Za-z0-9_]+(\\\.[-A-Za-z0-9_]+)*
 QUOTED = (\"[^"]*\"|\'[^']*\')
 PARENTESIS = \([^)]*\)
 INT = [0-9]+

diff --git a/test/floki/selector/parser_test.exs b/test/floki/selector/parser_test.exs
@@ -43,6 +43,14 @@ defmodule Floki.Selector.ParserTest do
     assert Parser.parse(tokens) == [%Selector{type: "img", id: "logo"}]
   end
 
+  test "id containing periods" do
+    tokens = tokenize("#my\\.example\\.com-port-filters.big.blue")
+
+    assert Parser.parse(tokens) == [
+             %Selector{id: "my.example.com-port-filters", classes: ["blue", "big"]}
+           ]
+  end
+
   test "class with attributes" do
     tokens =
       tokenize("""