Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing release scripts 0.5.0 beta.1 #712

Conversation

workingjubilee
Copy link
Member

So these don't quite work yet because when I run them

error: no matching package found
searched package name: `pgx`
prerelease package needs to be specified explicitly
pgx = { version = "0.5.0-beta.1" }
location searched: ~/tcdi/pgx/pgx
required by package `pgx-tests v0.5.0-beta.1 (~/tcdi/pgx/pgx-tests)`

Any suggestions?

Copy link
Contributor

@BradyBonnette BradyBonnette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've never ran the script before but I do remember there needs to be an order of crate publication.

update-versions.sh Outdated Show resolved Hide resolved
update-versions.sh Outdated Show resolved Hide resolved
@BradyBonnette
Copy link
Contributor

@workingjubilee

I added a commit after some of the things we discussed yesterday.

@workingjubilee
Copy link
Member Author

hella nice!

@workingjubilee workingjubilee marked this pull request as ready for review September 27, 2022 19:49
Comment on lines +71 to +72
./cargo-pgx/src/templates/cargo_toml
./nix/templates/default/Cargo.toml
Copy link
Member Author

@workingjubilee workingjubilee Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should invert ./nix/templates into ./templates/nix/ and have ./cargo-pgx/src/templates be its own template as well, and include them properly in the workspace and all that. Future PR, though, since now the release script at least works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very possible, though I am not too familiar with nix and any repercussions of moving the nix template file somewhere else.

update-versions.sh Outdated Show resolved Hide resolved
update-versions.sh Outdated Show resolved Hide resolved
update-versions.sh Outdated Show resolved Hide resolved
update-versions.sh Outdated Show resolved Hide resolved
update-versions.sh Outdated Show resolved Hide resolved
update-versions.sh Outdated Show resolved Hide resolved
update-versions.sh Outdated Show resolved Hide resolved
update-versions.sh Outdated Show resolved Hide resolved
update-versions.sh Outdated Show resolved Hide resolved
update-versions.sh Outdated Show resolved Hide resolved
@workingjubilee workingjubilee merged commit 5f2579d into pgcentralfoundation:develop Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants