-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing release scripts 0.5.0 beta.1 #712
Fixing release scripts 0.5.0 beta.1 #712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've never ran the script before but I do remember there needs to be an order of crate publication.
I added a commit after some of the things we discussed yesterday. |
hella nice! |
./cargo-pgx/src/templates/cargo_toml | ||
./nix/templates/default/Cargo.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should invert ./nix/templates
into ./templates/nix/
and have ./cargo-pgx/src/templates
be its own template as well, and include them properly in the workspace and all that. Future PR, though, since now the release script at least works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very possible, though I am not too familiar with nix and any repercussions of moving the nix template file somewhere else.
So these don't quite work yet because when I run them
Any suggestions?