Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multicast UDP listener support #412

Merged
merged 10 commits into from
Nov 7, 2022
Merged

feat: add multicast UDP listener support #412

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f944fa4
feat: add multicast UDP listener support
leki75 Oct 16, 2022
8632a30
add multicast tests
leki75 Nov 3, 2022
f35d864
Fix golangci-lint error
leki75 Nov 4, 2022
bd7f81d
Add IPv6 test on loopback interface
leki75 Nov 4, 2022
5960344
Fix golangci-lint error
leki75 Nov 4, 2022
2bc64db
Skip multicast IPv6 tests on Linux
leki75 Nov 7, 2022
eeadd08
Add MacOS workaround
leki75 Nov 7, 2022
aca68c9
Only call SetMulticastMembership when it is necessary
leki75 Nov 7, 2022
53a889e
Run IPv6 checks on Linux
leki75 Nov 7, 2022
91f25e7
Revert "Run IPv6 checks on Linux"
leki75 Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip multicast IPv6 tests on Linux
  • Loading branch information
@leki75
leki75 committed Nov 7, 2022
commit 2bc64db57bdd9b98cfc12536efab497b3589ba5f
7 changes: 5 additions & 2 deletions gnet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,9 @@ func TestServeMulticast(t *testing.T) {
t.Run("IPv6", func(t *testing.T) {
iface, err := findLoopbackInterface()
require.NoError(t, err)
if iface.Flags&net.FlagMulticast != net.FlagMulticast {
t.Skip("multicast is not supported on loopback interface")
}
// ff02::3 is an unassigned address from Link-Local Scope Multicast Addresses
// https://www.iana.org/assignments/ipv6-multicast-addresses/ipv6-multicast-addresses.xhtml#link-local
t.Run("udp-multicast", func(t *testing.T) {
Expand All @@ -451,11 +454,11 @@ func findLoopbackInterface() (*net.Interface, error) {
return nil, err
}
for _, iface := range ifaces {
if iface.Flags&(net.FlagLoopback|net.FlagMulticast) == net.FlagLoopback|net.FlagMulticast {
if iface.Flags&net.FlagLoopback == net.FlagLoopback {
return &iface, nil
}
}
return nil, errors.New("no loopback interface that supports multicast")
return nil, errors.New("no loopback interface")
}

func testMulticast(t *testing.T, addr string, reuseport, reuseaddr bool, index, nclients int) {
Expand Down