-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt: eliminate the fd->connection map when handling I/O events #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 85.08% 83.27% -1.82%
==========================================
Files 18 19 +1
Lines 1415 1477 +62
==========================================
+ Hits 1204 1230 +26
- Misses 158 188 +30
- Partials 53 59 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
0-haha
pushed a commit
to 0-haha/gnet
that referenced
this pull request
Jan 25, 2023
…2000#230) By default, `gnet` utilizes the standard package `golang.org/x/sys/unix` to implement pollers with `epoll` or `kqueue`, on the other hand, when users run `go build` with build tags `poll_opt`, like this: `go build -tags=poll_opt`, `gnet` will switch to the optimized implementation by invoking the system calls of `epoll` or `kqueue` directly, which eliminates the HASH MAP of `fd->conn`, it ought to achieve a higher performance with this optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
gnet
utilizes the standard packagegolang.org/x/sys/unix
to implement pollers withepoll
orkqueue
, on the other hand, when users rungo build
with build tagspoll_opt
, like this:go build -tags=poll_opt
,gnet
will switch to the optimized implementation by invoking the system calls ofepoll
orkqueue
directly, which eliminates the HASH MAP offd->conn
, it ought to achieve a higher performance with this optimization.