Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Optimize resources/icons #6941

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

ggdouglas
Copy link
Contributor

@ggdouglas ggdouglas commented Aug 15, 2024

Fixes #0000

⚠️ [Warning] Looking at the "Files changed" diff on this PR will likely overload your browser tab! ⚠️

Optimize icons versioned in resources/icons.

These icons were optimized using SVGO v3.3.2 with the following config:

// svgo.config.mjs

export default {
  js2svg: {
    indent: 2,
    pretty: true,
  },
  plugins: [
    // run non-default plugins first (run order is important)
    "removeDimensions",
    {
      name: "removeAttrs",
      params: {
        attrs: [
          "svg:(id|version|xml.space|xmlns.xlink)",
          "clip-rule|fill-rule|fill",
        ],
      },
    },
    "preset-default",
  ],
};

These icons required manual re-exporting (have elements that are non-trivial to optimize via script):

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Screenshot 2024-08-15 at 11 03 33@2x

@svc-palantir-github
Copy link

Optimize icons

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas self-assigned this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants