Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: transparent shares #11505

Merged
merged 1 commit into from
Sep 5, 2024
Merged

feat: transparent shares #11505

merged 1 commit into from
Sep 5, 2024

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Sep 3, 2024

Description

Adds transparent sharing so share receivers can see other sharees when they have the permissions to do so.

Quite a bit of refactoring was needed for this because we didn't really support root spaces having shares. Personal spaces don't have any. Project spaces do, however, we handled them completely separate in the spaces store (via the spaceMembers prop).

Now that share root spaces can have shares, I added functionality so those shares are being handled like regular indirect folder shares within the space. I also refactored space member shares to align with that. This might be a bit confusing at first sight, but IMO it's a lot cleaner now because it's the same for all kinds of spaces.

To test the transparent sharing part you need owncloud/ocis#9943.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Sep 3, 2024
Copy link

update-docs bot commented Sep 3, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen force-pushed the feat/transparent-shares branch 4 times, most recently from 815eba9 to 89e0a7c Compare September 3, 2024 10:50
Copy link

sonarcloud bot commented Sep 3, 2024

@JammingBen JammingBen marked this pull request as ready for review September 3, 2024 13:33
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope I didn't miss anything... quite cumbersome to review. 😅 Good stuff, thank you! Also gave it a spin in the dev environment, worked like a charm. I found it quite confusing that the share roles Can view and Can edit with and without permission to list permissions have the same title. But that's not part of this repo anymore...

@JammingBen JammingBen merged commit fb22860 into master Sep 5, 2024
3 checks passed
@kulmann kulmann deleted the feat/transparent-shares branch September 5, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web] Personal: Show all share-receivers in shares panel
2 participants