chore: remove font-awesome dependency #11421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
1 task
kulmann
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Cool, thank you! 💪 We had the lib only for displaying the attribution in the browser console, you got that right. 👏
Edit: Also correct that we have the attribution in the .svg file source and that the license always stated that that's sufficient. We just had the browser log additionaly "just to be sure".
As far as I can see, the dependency was only used to display the attribution in the browser console. However, this attribution has been removed with their version `6.6.0`. Also, according to https://fontawesome.com/license/free it's sufficient to have the attribution embedded in the downloaded icons (which we have).
JammingBen
force-pushed
the
chore/remove-font-awesome
branch
from
784b516
to
3bbd0a9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As far as I can see, the dependency was only used to display the attribution in the browser console. However, this attribution has been removed with their version
6.6.0.Also, according to https://fontawesome.com/license/free it's sufficient to have the attribution embedded in the downloaded icons (which we have).
Superseds #11418.
Types of changes