ut,multi net: Fix assertion in case of unexpected error #4747
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/unit-testing
In case there is an unexpected error, for a test that should pass, there will be a panic because the matcher expects non nil value. Fix it to be explicit and also print the error to ease debug. Signed-off-by: Or Shoval <oshoval@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does and why is it needed
In case there is an unexpected error, for a test that should pass,
there will be a panic because the matcher expects non nil value.
Fix it to be explicit and also print the error to ease debug.
Which issue(s) this PR fixes
Fixes #
Special notes for reviewers
If desired i can cherry-pick it to #4732
to reduce one review, but it is not related to that PR.
How to verify it
Details to documentation updates
Description for the changelog
Does this PR introduce a user-facing change?