Return an error while adding nodes if duplicate chassis id is detected #4739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While multiple nodes gets same chassis id, POD to POD connectivity between newly added node and all other existing nodes gets impacted due to several missing OVN flows and OpenFlows. Chassis ID is generally obtained from /etc/openvswitch/system-id.conf and this file gets created while starting up Opevswitch. While the chances of duplicate Openvswitch system ID created for multiple nodes is very thin but not impossible. This commit returns an error if duplicate chassis id is detected while adding a new node. Signed-off-by: Arnab Ghosh <arnabghosh89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While multiple nodes gets same chassis id, POD to POD connectivity between newly added node and all other existing nodes gets impacted due to several missing OVN flows and OpenFlows.
Chassis ID is generally obtained from /etc/openvswitch/system-id.conf and this file gets created while starting up Opevswitch. While the chances of duplicate Openvswitch system ID created for multiple nodes is very thin but not impossible.
This commit returns an error if duplicate chassis id is detected while adding a new node.
What this PR does and why is it needed
Which issue(s) this PR fixes
Fixes #
Special notes for reviewers
How to verify it
Details to documentation updates
Description for the changelog
Does this PR introduce a user-facing change?