-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip cluster port group operations for UDN #4738
base: master
Are you sure you want to change the base?
Conversation
6662803
to
b0c2a8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If CI passes this looks good to me, thanks!
@tssurya we might want a more descriptive name than |
updated the PR description, I guess the first thing that pops into the reviewers head when they hear fix noise is... what noise.. then they will read the PR description which had details but.. your method is more efficient where I just tell that in the title ;) you win. |
We kept trying to add the management port for secondary networks into the cluster port group of secondary networks. But that port group doesn't exist yet. It will exist once we get ovn-org#4547 merged but until then this is causing infinite retries from syncMgmtPort erroring out. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
b0c2a8a
to
0055e7f
Compare
We kept trying to add the management port
for secondary networks into the cluster
port group of secondary networks.
But that port group doesn't exist yet.
It will exist once we get #4547 merged but until then this is causing
infinite retries from syncMgmtPort
erroring out. So let's skip this for now
PS: Not really infinite, only 15 times..