Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Update README.md #1

merged 1 commit into from
Nov 15, 2021
+1 −1

Conversation

dwisth
Copy link
Contributor

@dwisth dwisth commented Nov 12, 2021

No description provided.

@dwisth
Copy link
Contributor Author

dwisth commented Nov 12, 2021

More comments:

  • Maybe print "success" or "writing file to allan_variance.csv` at end of main function.
  • What are the circles and stars in the graphs.
  • Mention dataset needs to be stationary (you just mentioned to record the data).

@dwisth
Copy link
Contributor Author

dwisth commented Nov 12, 2021

Maybe compress the rosbag?
e.g. rosbag compress --lz4 allan_variance_2021-10-12-10-01-42_cooked.bag compresses the rosbag from 2.1GB to 284MB.

@dwisth
Copy link
Contributor Author

dwisth commented Nov 12, 2021

Final comment: Maybe you could add a unit test by adding fake angular velocity and acceleration measurements, using std::normal_distribution to add noise? Might be a bigger task though.

@raabuchanan raabuchanan self-requested a review November 15, 2021 17:04
@raabuchanan raabuchanan merged commit 4daaa4a into master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raabuchanan raabuchanan raabuchanan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwisth @raabuchanan