Skip to content

Commit

Permalink
OHRM5X-1507: Add SVG client logo & banner support to layout (#449)
Browse files Browse the repository at this point in the history
* OHRM5X-1507: Add SVG support for layout

* OHRM5X-1507: Append version to title

* OHRM5X-1507: Change storybook favicon
  • Loading branch information
RajithaKumara committed Jul 7, 2022
1 parent e87fbec commit 7d4e748
Show file tree
Hide file tree
Showing 9 changed files with 13 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Lint
on: [push, pull_request]

jobs:
build:
lint:
runs-on: ubuntu-latest

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Unit Tests
on: [push, pull_request]

jobs:
build:
test:
runs-on: ubuntu-latest

steps:
Expand Down
2 changes: 1 addition & 1 deletion components/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "oxd-components",
"version": "1.0.6-alpha.9",
"version": "1.0.6-alpha.10",
"license": "GPL-3.0",
"scripts": {
"test:unit": "vue-cli-service test:unit",
Expand Down
6 changes: 4 additions & 2 deletions components/src/core/components/SidePanel/branding.scss
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@
}
}
&-banner {
height: $oxd-brand-banner-height;
width: $oxd-brand-banner-width;
& img {
height: $oxd-brand-banner-height;
width: $oxd-brand-banner-width;
}
&.toggled {
@include oxd-respond-to('md') {
display: none;
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "oxd",
"license": "GPL-3.0",
"version": "1.0.6-alpha.9",
"version": "1.0.6-alpha.10",
"private": true,
"workspaces": [
"components",
Expand Down
1 change: 1 addition & 0 deletions storybook/.storybook/manager-head.html
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<link rel="shortcut icon" href="orange.ico" />
3 changes: 2 additions & 1 deletion storybook/.storybook/manager.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import {addons} from '@storybook/addons';
import {create} from '@storybook/theming';
import {version} from '../../package.json';

const orangehrmTheme = create({
base: 'light',
brandTitle: 'OXD Storybook',
brandTitle: `OXD Storybook - ${version}`,
brandUrl: 'https://www.orangehrm.com',
brandImage:
'https://www.orangehrm.com/themes/orangehrm-modern/static/images/logo.png',
Expand Down
4 changes: 2 additions & 2 deletions storybook/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"version": "1.0.0",
"license": "GPL-3.0",
"scripts": {
"start": "start-storybook -p 6006",
"build": "build-storybook -o ./dist"
"start": "start-storybook -p 6006 -s public",
"build": "build-storybook -o ./dist -s public"
},
"devDependencies": {
"@babel/core": "^7.12.10",
Expand Down
Binary file added storybook/public/orange.ico
Binary file not shown.

0 comments on commit 7d4e748

Please sign in to comment.