fix: avoid unnecessary initial filter loading state #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use all manual attributions as filtered attributions when no filter is set - separate concerns of signals worker hook from those of the hooks accessing variables from the Redux store closes #2502 Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow
force-pushed
the
fix-avoid-unnecessary-initial-filter-load-times
branch
from
5f1bb8c
to
26144b0
Compare
|
|
||
| export const FOLDER_PROGRESS_DATA = 'folder-progress-data'; | ||
|
|
||
| export function useFolderProgressData() { |
There was a problem hiding this comment.
We could also have the simple hooks accumulated in one file, but I think it is nice to have them separated like you did it.
There was a problem hiding this comment.
yes, i was considering along the same lines
| import { getManualAttributions } from '../selectors/all-views-resource-selectors'; | ||
| import { useVariable } from './use-variable'; | ||
|
|
||
| export const FILTERED_ATTRIBUTIONS = 'filtered-attributions'; |
There was a problem hiding this comment.
We should always do that 👍
I was thinking we could add _KEY to these variable names to make their purpose clear.
Comment on lines
+44
to
+47
| setFilteredAttributions((prev) => ({ | ||
| ...prev, | ||
| attributions, | ||
| })); |
There was a problem hiding this comment.
Why do we pass an arrow function here instead of just passing attributions?
Suggested change
| setFilteredAttributions((prev) => ({ | |
| ...prev, | |
| attributions, | |
| })); | |
| setFilteredAttributions( | |
| attributions, | |
| ); |
There was a problem hiding this comment.
because i need to preserve the other attributes that are inside prev but not part of attributions
| }); | ||
| }); | ||
|
|
||
| it('sends selected filters when some are set', () => { |
| useFilteredAttributions, | ||
| } from '../use-filtered-attributions'; | ||
|
|
||
| describe('useFilteredAttributions', () => { |
antonbauhofer
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Context and reason for change
closes #2502
How can the changes be tested
Open a large Opossum file and notice that the attribution list immediately displays attributions without any filter loading spinner spinning.