Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/copy project with required custom fields #6083

Merged
merged 4 commits into from
Dec 14, 2017

Conversation

ulferts
Copy link
Contributor

@ulferts ulferts commented Dec 14, 2017

Fixes:

  • Uses values of custom fields in source project to fill the fields in the project copy form. That way, the user can choose to keep the values or to alter them. The explicit option to copy the project custom fields has been removed as it was unclear what was to happen when the user sets the custom values via the form while choosing to have them copied. https://community.openproject.com/projects/openproject/work_packages/26795
  • Copied work packages will also have the custom values of the source custom field.

Cleans up:

  • before action not in use
  • cuke that was rewritten as a feature spec
  • controller code

The option, whether to copy custom_values is replaced by always filling in the values from the copied from project
@oliverguenther
Copy link
Member

LGTM 👍

@oliverguenther oliverguenther merged commit e8930af into dev Dec 14, 2017
@oliverguenther oliverguenther deleted the fix/copy_project_with_required_custom_fields branch December 14, 2017 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants