-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use transit model time zone in debug UI #6087
Use transit model time zone in debug UI #6087
Conversation
b73e947
to
208c8ad
Compare
cfc9a2b
to
c09387b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6087 +/- ##
==========================================
Coverage 69.81% 69.81%
Complexity 17418 17418
==========================================
Files 1974 1974
Lines 74537 74545 +8
Branches 7633 7633
==========================================
+ Hits 52040 52047 +7
- Misses 19847 19848 +1
Partials 2650 2650 ☔ View full report in Codecov by Sentry. |
Will this work for those folks who have the REST api turned off? |
This is a different feature flag: OpenTripPlanner/src/main/java/org/opentripplanner/framework/application/OTPFeature.java Line 18 in 39e2ab6
|
f76682d
to
0be72d3
Compare
@testower This is now using GraphQL to fetch the time zone. |
src/main/resources/org/opentripplanner/apis/transmodel/schema.graphql
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Gran <t2gran@gmail.com>
src/main/java/org/opentripplanner/apis/transmodel/model/framework/ServerInfoType.java
Outdated
Show resolved
Hide resolved
…ork/ServerInfoType.java
src/main/resources/org/opentripplanner/apis/transmodel/schema.graphql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the Java Code changes, and they looks ok - so this can be merged, one review on the Debug UI is enough for this.
Summary
Reads the transit model time zone from the server and uses it to format times in the debug UI. For this to work, I exposed the transit model time zone on the server info REST endpoint.
I added a few messages to the UI that tells you the time zone being used:
This PR also combines the date and time input into a single date-time one which makes it much easier to convert between the local and zoned date time. The combined input looks like this: