Fix coach and trolleybus extended GTFS route types #6086
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6086 +/- ##
==========================================
Coverage ? 69.81%
Complexity ? 17422
==========================================
Files ? 1974
Lines ? 74537
Branches ? 7633
==========================================
Hits ? 52040
Misses ? 19846
Partials ? 2651 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Due to OTP's complexity, I'm afraid there is no such thing as a trivial change anymore and we expect you to write a test for every PR. Luckily, testing this this is quite easy and you can add more test cases to the existing ones.
On top of this, using COACH instead BUS may be the correct thing to do for the 200-299 type range but it is a breaking change so we will need to check with the relevant users.
| @@ -19,7 +19,7 @@ public static TransitMode mapMode(int routeType) { | |||
| if (routeType >= 100 && routeType < 200) { // Railway Service | |||
| return TransitMode.RAIL; | |||
| } else if (routeType >= 200 && routeType < 300) { //Coach Service | |||
There was a problem hiding this comment.
I know that you didn't do this but can you convert all trailing comments to line comments, please?
Summary
Fix GTFS extended route types for coach (2xx) and trolleybus (8xx)
Issue
Fixes #5550
Unit tests
None needed - trivial changes
Documentation
None needed - trivial changes