Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add U-turn costs for car routing #5956

Draft
wants to merge 2 commits into
base: dev-2.x
Choose a base branch
from

Conversation

hbruch
Copy link
Contributor

@hbruch hbruch commented Jul 8, 2024

Summary

This PR adds a (hard coded) cost for car U-turns in case the turnAngle is between (hard coded) angles 170 and 190.

This PR is an alternative to #5985, which reuses pre-existing split vertices instead of creating a split vertex for every edge to be split.

Issue

Closes #5955.

Unit tests

This PR provides a testcase to illustrate #5955. No testcase had to be updated for this fix.

Bumping the serialization version id

No changes to serialization.

@hbruch hbruch requested a review from a team as a code owner July 8, 2024 11:17
@hbruch hbruch marked this pull request as draft July 8, 2024 11:17
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (de56d00) to head (5567b4c).

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #5956   +/-   ##
==========================================
  Coverage      69.64%   69.64%           
- Complexity     17164    17172    +8     
==========================================
  Files           1943     1943           
  Lines          73795    73804    +9     
  Branches        7552     7554    +2     
==========================================
+ Hits           51394    51404   +10     
  Misses         19772    19772           
+ Partials        2629     2628    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbruch hbruch marked this pull request as ready for review July 25, 2024 11:09
@hbruch hbruch changed the title Add U-turn costs for car routing (WIP) Add U-turn costs for car routing Jul 25, 2024
@leonardehrenfried
Copy link
Member

I will convert this to a draft. You can convert it back to a PR when you start working on it again.

@leonardehrenfried leonardehrenfried marked this pull request as draft September 3, 2024 12:45
@t2gran t2gran added this to the 2.7 (next release) milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

U-turns not prevented at split edges
3 participants