-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add headway to GTFS GraphQL API #5951
base: dev-2.x
Are you sure you want to change the base?
Conversation
non-strict frequency trips, but could become important for real-time trips, strict frequency | ||
trips, and scheduled trips with empirical headways. | ||
""" | ||
headway: Int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you return a Duration
here? We already have the scalar for it.
@@ -163,6 +165,15 @@ public static GraphQLObjectType create( | |||
.dataFetcher(env -> leg(env).getDuration().toSeconds()) | |||
.build() | |||
) | |||
.field( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using this API or the GTFS one? If you don't use it, you don't need to add this code here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5951 +/- ##
==========================================
Coverage 69.46% 69.46%
+ Complexity 17075 17074 -1
==========================================
Files 1937 1937
Lines 73717 73725 +8
Branches 7546 7546
==========================================
+ Hits 51204 51211 +7
Misses 19882 19882
- Partials 2631 2632 +1 ☔ View full report in Codecov by Sentry. |
Please also add a test for the new field.
|
I'm going to convert this to a draft. Once you start working on it again, you can turn it back into a PR. |
Summary
This PR adds headway to Plan Itinerary.Leg
Issue
#5950
Unit tests
No Unit test required
Documentation