Add a matcher API for filters in the transit service used for datedServiceJourneyQuery #5713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5713 +/- ##
=============================================
+ Coverage 67.81% 69.76% +1.94%
- Complexity 16574 17366 +792
=============================================
Files 1914 1970 +56
Lines 72389 74378 +1989
Branches 7442 7604 +162
=============================================
+ Hits 49090 51887 +2797
+ Misses 20780 19846 -934
- Partials 2519 2645 +126 ☔ View full report in Codecov by Sentry. |
t2gran
requested changes
Mar 4, 2024
src/main/java/org/opentripplanner/transit/api/request/TripOnServiceDateRequest.java
Outdated
Show resolved
Hide resolved
...n/java/org/opentripplanner/transit/model/filter/transit/TripOnServiceDateMatcherFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/apis/transmodel/model/timetable/DatedServiceJourneyQuery.java
Outdated
Show resolved
Hide resolved
eibakke
changed the title
src/main/java/org/opentripplanner/transit/api/request/TripOnServiceDateRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/apis/transmodel/model/timetable/DatedServiceJourneyQuery.java
Outdated
Show resolved
Hide resolved
leonardehrenfried
previously approved these changes
Mar 6, 2024
There was a problem hiding this comment.
This looks good to me now. I hope I haven't requested anything that @t2gran will want to change back.
t2gran
requested changes
Mar 19, 2024
src/main/java/org/opentripplanner/framework/collection/CollectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/framework/collection/CollectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/transit/api/request/TripOnServiceDateRequestBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/transit/model/filter/expr/ContainsMatcher.java
Show resolved
Hide resolved
src/main/java/org/opentripplanner/transit/model/filter/expr/ContainsMatcher.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/transit/model/filter/expr/EqualityMatcher.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/transit/model/filter/expr/EqualityMatcher.java
Outdated
Show resolved
Hide resolved
t2gran
requested changes
Apr 18, 2024
src/main/java/org/opentripplanner/apis/transmodel/model/timetable/DatedServiceJourneyQuery.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/transit/api/request/TripOnServiceDateRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/transit/api/request/TripOnServiceDateRequestBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/transit/api/request/TripOnServiceDateRequestBuilder.java
Show resolved
Hide resolved
src/main/java/org/opentripplanner/apis/transmodel/model/timetable/DatedServiceJourneyQuery.java
Show resolved
Hide resolved
src/main/java/org/opentripplanner/apis/transmodel/model/timetable/DatedServiceJourneyQuery.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/apis/transmodel/model/timetable/DatedServiceJourneyQuery.java
Outdated
Show resolved
Hide resolved
… DatedServiceJourneyQuery. This is the first simple implementation of a filter using the unified matcher API.
…and in a logically consistent manner. Also does List.copyOf instead of simple reassignment between TripOnServiceDateRequestBuilder and TripOnServiceDateRequest.
…d removes get prefix from getters.
…estions from code review. Also improves documentation generally.
|
I think a git rebase went wrong here. |
eibakke
force-pushed
the
trip-on-day-filter
branch
from
f361f01
to
153fe56
Compare
t2gran
approved these changes
Sep 23, 2024
leonardehrenfried
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make use of it in the DatedServiceJourneyQuery
This is the first simple implementation of a filter using the unified matcher API.
Issue
#5630
Unit tests
Added unit tests for each matcher and the new TripOnServiceDateMatcherFactory. Also ensured that the API in local runs behaves as expected.
Documentation
Added JavaDoc.