Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rbac list and enable secret backups #14573

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

jupierce
Copy link
Contributor

@jupierce jupierce commented Jan 4, 2021

The 'list' verb will not work in conjunction with named resources.
Here we remove those named resources.
We also add the ability for ART to read the upgrade graph secret
so that it can backup that resource periodically.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2021
@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2021
The 'list' verb will not work in conjunction with named resources.
Here we remove those named resources.
We also add the ability for ART to read the upgrade graph secret
so that it can backup that resource periodically.
Copy link
Contributor

@bradmwilliams bradmwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bradmwilliams, jupierce
To complete the pull request process, please assign bbguimaraes after the PR has been reviewed.
You can assign the PR to them by writing /assign @bbguimaraes in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2021
@jupierce jupierce merged commit 2cf4041 into openshift:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants