-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search pipeline README #9825
Add search pipeline README #9825
Conversation
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 534b03f Incompatible componentsIncompatible components: [https://github.com/opensearch-project/k-nn.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 56550a8 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git] |
@msfroh will probably have some comments! |
modules/search-pipeline-common/src/main/java/org/opensearch/search/pipeline/common/README.md
Outdated
Show resolved
Hide resolved
modules/search-pipeline-common/src/main/java/org/opensearch/search/pipeline/common/README.md
Outdated
Show resolved
Hide resolved
modules/search-pipeline-common/src/main/java/org/opensearch/search/pipeline/common/README.md
Outdated
Show resolved
Hide resolved
modules/search-pipeline-common/src/main/java/org/opensearch/search/pipeline/common/README.md
Outdated
Show resolved
Hide resolved
modules/search-pipeline-common/src/main/java/org/opensearch/search/pipeline/common/README.md
Outdated
Show resolved
Hide resolved
modules/search-pipeline-common/src/main/java/org/opensearch/search/pipeline/common/README.md
Outdated
Show resolved
Hide resolved
modules/search-pipeline-common/src/main/java/org/opensearch/search/pipeline/common/README.md
Outdated
Show resolved
Hide resolved
modules/search-pipeline-common/src/main/java/org/opensearch/search/pipeline/common/README.md
Outdated
Show resolved
Hide resolved
modules/search-pipeline-common/src/main/java/org/opensearch/search/pipeline/common/README.md
Outdated
Show resolved
Hide resolved
I was right in the middle of writing them! |
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change b27ed5a Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
modules/search-pipeline-common/src/main/java/org/opensearch/search/pipeline/common/README.md
Outdated
Show resolved
Hide resolved
modules/search-pipeline-common/src/main/java/org/opensearch/search/pipeline/common/README.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Thanks @scrawfor99! This looks great. Can you move the file to the root of the module (i.e. to It looks like the license header checker expects everything under |
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Flaky test since I only made a README. Should be all set. Thanks for all the help @msfroh |
@scrawfor99 -- can you just merge the latest from |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9825 +/- ##
============================================
- Coverage 71.19% 71.02% -0.17%
+ Complexity 58194 58108 -86
============================================
Files 4827 4827
Lines 274248 274262 +14
Branches 39962 39966 +4
============================================
- Hits 195239 194783 -456
- Misses 62660 63180 +520
+ Partials 16349 16299 -50
|
Codecov is mistaken. This README didn't lower coverage. 😁 |
--------- Signed-off-by: Stephen Crawford <steecraw@amazon.com>
--------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
--------- Signed-off-by: Stephen Crawford <steecraw@amazon.com>
--------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
[Describe what this change achieves]
This PR adds a README file in the
search-pipeline-common
module. The document describes the process of creating a search pipeline as shared on the documentation website but also explains the process of creating a new search processor.Since we include the Search pipeline as part of OpenSearch it seems like we should include the basic information on the module. Right now there is not much documentation inside the code itself.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
N/A
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.