Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search latency - Coordinator] Changing version check to 2.11 #10280

Merged
merged 2 commits into from
Sep 30, 2023

Conversation

sgup432
Copy link
Contributor

@sgup432 sgup432 commented Sep 29, 2023

Description

Changing version check to 2.11. Original PR - #8386
Backport PR - #10279

Also merging this PR - #10271

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
@sgup432
Copy link
Contributor Author

sgup432 commented Sep 29, 2023

@msfroh We might have to skip changelog for this.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

Compatibility status:

Checks if related components are compatible with change bb0df81

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@msfroh
Copy link
Collaborator

msfroh commented Sep 29, 2023

@sgup432 , can you please add the commit from #10271 to your PR?

Right now, it's blocking you and you're blocking it. I should have merged it before merging your backport PR. 😦

Essentially, I think we need both changes in a single PR.

[Backport 2.x] Indexing: add Doc status counter (opensearch-project#10267)

* Indexing: add Doc Status Counter (opensearch-project#8716)

Currently, Opensearch returns a 200 OK response code for a Bulk API
call, even though there can be partial/complete failures within the
request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc.

Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
(cherry picked from commit d656e3d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 94173e3)
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
@sgup432
Copy link
Contributor Author

sgup432 commented Sep 29, 2023

@msfroh Merged #10271 changes into this PR!

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.index.shard.RemoteIndexShardTests.testNRTReplicaWithRemoteStorePromotedAsPrimaryCommitCommit

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #10280 (bb0df81) into main (d656e3d) will decrease coverage by 0.12%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main   #10280      +/-   ##
============================================
- Coverage     71.24%   71.12%   -0.12%     
+ Complexity    58260    58257       -3     
============================================
  Files          4830     4830              
  Lines        274575   274575              
  Branches      40015    40015              
============================================
- Hits         195629   195303     -326     
- Misses        62570    62950     +380     
+ Partials      16376    16322      -54     
Files Coverage Δ
...org/opensearch/index/search/stats/SearchStats.java 82.02% <0.00%> (ø)
...java/org/opensearch/index/shard/IndexingStats.java 86.61% <0.00%> (ø)

... and 507 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT:
  • URL:
  • CommitID: bb0df81
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

2 similar comments
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT:
  • URL:
  • CommitID: bb0df81
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT:
  • URL:
  • CommitID: bb0df81
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@msfroh msfroh merged commit be24766 into opensearch-project:main Sep 30, 2023
12 of 13 checks passed
@sgup432 sgup432 deleted the search_latency_version_guard branch September 30, 2023 07:05
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Oct 3, 2023
…arch-project#10280)

* [Search latency - Coordinator] Changing version check to 2.11

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

* [Port main] update version check as per v2.11.0

[Backport 2.x] Indexing: add Doc status counter (opensearch-project#10267)

* Indexing: add Doc Status Counter (opensearch-project#8716)

Currently, Opensearch returns a 200 OK response code for a Bulk API
call, even though there can be partial/complete failures within the
request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc.

Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
(cherry picked from commit d656e3d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 94173e3)
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

---------

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 9, 2023
…arch-project#10280)

* [Search latency - Coordinator] Changing version check to 2.11

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

* [Port main] update version check as per v2.11.0

[Backport 2.x] Indexing: add Doc status counter (opensearch-project#10267)

* Indexing: add Doc Status Counter (opensearch-project#8716)

Currently, Opensearch returns a 200 OK response code for a Bulk API
call, even though there can be partial/complete failures within the
request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc.

Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
(cherry picked from commit d656e3d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 94173e3)
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

---------

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
…arch-project#10280)

* [Search latency - Coordinator] Changing version check to 2.11

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

* [Port main] update version check as per v2.11.0

[Backport 2.x] Indexing: add Doc status counter (opensearch-project#10267)

* Indexing: add Doc Status Counter (opensearch-project#8716)

Currently, Opensearch returns a 200 OK response code for a Bulk API
call, even though there can be partial/complete failures within the
request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc.

Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
(cherry picked from commit d656e3d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 94173e3)
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

---------

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…arch-project#10280)

* [Search latency - Coordinator] Changing version check to 2.11

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

* [Port main] update version check as per v2.11.0

[Backport 2.x] Indexing: add Doc status counter (opensearch-project#10267)

* Indexing: add Doc Status Counter (opensearch-project#8716)

Currently, Opensearch returns a 200 OK response code for a Bulk API
call, even though there can be partial/complete failures within the
request E2E. This provides doc level stats with respect to the rest status code as 2xx, 4xx, 5xx etc.

Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
(cherry picked from commit d656e3d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 94173e3)
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

---------

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants