Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324125: Improve class initialization barrier in TemplateTable::_new for RISC-V #17548

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/hotspot/cpu/riscv/templateTable_riscv.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3547,11 +3547,10 @@ void TemplateTable::_new() {
// get InstanceKlass
__ load_resolved_klass_at_offset(x14, x13, x14, t0);

// make sure klass is initialized & doesn't have finalizer
// make sure klass is fully initialized
__ lbu(t0, Address(x14, InstanceKlass::init_state_offset()));
__ sub(t1, t0, (u1)InstanceKlass::fully_initialized);
__ bnez(t1, slow_case);
// make sure klass is initialized
assert(VM_Version::supports_fast_class_init_checks(),
"Optimization requires support for fast class initialization checks");
__ clinit_barrier(x14, t0, nullptr /*L_fast_path*/, &slow_case);

// get instance_size in InstanceKlass (scaled to a count of bytes)
__ lwu(x13, Address(x14, Klass::layout_helper_offset()));
Expand Down