Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blockly] http block documentation #2359

Merged
merged 6 commits into from
Sep 14, 2024
Merged

Conversation

mherwege
Copy link
Contributor

Changed the documentation to have the new functionality from openhab/openhab-webui#2607 and changed the pictures to also show the extra mutator icon.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Copy link

netlify bot commented Aug 31, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit 90c1fa0
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/66e340eb4a8ba9000731e257
😎 Deploy Preview https://deploy-preview-2359--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege
Copy link
Contributor Author

mherwege commented Sep 1, 2024

Maybe wait a little with this until I figure out if we could do openhab/openhab-webui#2607 (comment) without breaking anything.

stefan-hoehn and others added 2 commits September 5, 2024 22:10
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, much appreciated as I am aware that blockly docs require all these images 🙏🏻

However, there is a lint error

configuration/blockly/rules-blockly-http.md:79:174 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

@stefan-hoehn stefan-hoehn added this to the 4.3 milestone Sep 12, 2024
@mherwege
Copy link
Contributor Author

Sorry for that. I hope it is OK now.

@stefan-hoehn stefan-hoehn merged commit 09a2650 into openhab:main Sep 14, 2024
5 checks passed
@mherwege mherwege deleted the blockly_http branch September 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants