Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Kafka Compression codec #53

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Kafka Compression codec #53

merged 2 commits into from
Nov 22, 2021

Conversation

glutamatt
Copy link
Contributor

Description

Enable a setting for Kafka compression codec : defined https://github.com/Shopify/sarama/blob/a37f45dcee6b1e95240c17a4c60c4a960d50eaeb/message.go#L33

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #53 (fad677c) into main (1694d8e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   81.55%   81.57%   +0.01%     
==========================================
  Files          27       27              
  Lines        2174     2176       +2     
==========================================
+ Hits         1773     1775       +2     
  Misses        314      314              
  Partials       87       87              
Impacted Files Coverage Δ
pkg/handler/data_recorder_kafka.go 73.14% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1694d8e...fad677c. Read the comment docs.

pkg/config/env.go Outdated Show resolved Hide resolved
Co-authored-by: Zhuojie Zhou <zhouzhuojie@users.noreply.github.com>
@zhouzhuojie zhouzhuojie merged commit 88902d1 into openflagr:main Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants