Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: responsiveness on library authoring sidebar [FC-0062] #1293

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Sep 17, 2024

Description

This PR fixes the library authoring sidebar width and change the card grid to have auto-columns instead for breakpoints.

Before:

image

After:

image

Responsiveness:

sidebar-responsiveness-fixed

Tabs

sidebar-responsiveness-tabs

More information

Part of:

Testing instructions

  • Checkout this branch
  • Open the library authoring page for a library with some components
  • Resize the screen and check the responsiveness for the 'Components` and the 'Collections' tabs.

Private ref: FAL-3820

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 17, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 17, 2024

Thanks for the pull request, @rpenido!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@rpenido rpenido changed the title fix: responsiveness on library authoring sidebar fix: responsiveness on library authoring sidebar [FC-0062] Sep 17, 2024
@rpenido rpenido force-pushed the rpenido/fal-3820-adjust-sidebar-responsiveness branch from f815e38 to caee0dc Compare September 17, 2024 20:02
@rpenido rpenido marked this pull request as ready for review September 17, 2024 20:11
@rpenido rpenido requested a review from a team as a code owner September 17, 2024 20:11
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (82a3b7c) to head (124bd94).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1293      +/-   ##
==========================================
+ Coverage   92.34%   92.47%   +0.12%     
==========================================
  Files        1023     1025       +2     
  Lines       18877    18975      +98     
  Branches     4023     4034      +11     
==========================================
+ Hits        17432    17547     +115     
+ Misses       1376     1360      -16     
+ Partials       69       68       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bradenmacdonald
Copy link
Contributor

Looks nice @rpenido! Does this also make the width of the sidebar more stable/consistent?

@rpenido
Copy link
Contributor Author

rpenido commented Sep 17, 2024

Looks nice @rpenido! Does this also make the width of the sidebar more stable/consistent?

Yes! The width is now fixed on 450px despite the content.

Edit: the sandbox is updated with this change

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Sep 17, 2024
src/index.scss Show resolved Hide resolved
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @rpenido This is working great, and fixes the horizontal jiggle that Sam noticed.

There's still a slight vertical shifting when switching between Library and Component info sidebars, maybe because of the outline on the Library Info button? Would be cool if you could fix that too, but doesn't have to block us here.

vertical_jiggle.mp4
  • I tested this on my tutor devstack using the PR test instructions.
  • I read through the code
  • I checked for accessibility issues by using my keyboard to navigate
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

@rpenido
Copy link
Contributor Author

rpenido commented Sep 18, 2024

There's still a slight vertical shifting when switching between Library and Component info sidebars, maybe because of the outline on the Library Info button? Would be cool if you could fix that too, but doesn't have to block us here.

Good catch @pomegranited!
FIxed here: 9607acc

@bradenmacdonald bradenmacdonald merged commit fc4b700 into openedx:master Sep 18, 2024
7 checks passed
@bradenmacdonald bradenmacdonald deleted the rpenido/fal-3820-adjust-sidebar-responsiveness branch September 18, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants