Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin django-wiki #31681

Merged
merged 1 commit into from
Feb 1, 2023
Merged

fix: pin django-wiki #31681

merged 1 commit into from
Feb 1, 2023

Conversation

aht007
Copy link
Member

@aht007 aht007 commented Feb 1, 2023

Description

Upgrade Job is failing due to dependency conflicts in newer version of openedx-django-wiki and bleech constraint in edx-platform. This PR pins django-wiki version. This constraint will be removed in #31678

@@ -771,7 +775,7 @@ ora2==4.5.1
# via -r requirements/edx/base.in
oscrypto==1.3.0
# via snowflake-connector-python
outcome-surveys==1.1.1
outcome-surveys==2.0.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muhammad-ammar I can see that you released this package. Is it safe to upgrade?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aht007 Yes.

@@ -1051,7 +1056,7 @@ slumber==0.7.1
# edx-bulk-grades
# edx-enterprise
# edx-rest-api-client
snowflake-connector-python==2.9.0
snowflake-connector-python==3.0.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing breaking.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -4,7 +4,7 @@
#
# make upgrade
#
pip==22.3.1
pip==23.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no backwards incompatible changes found in the changelogs

Copy link
Member Author

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All package upgrades look good to me

@aht007 aht007 mentioned this pull request Feb 1, 2023
@aht007 aht007 self-assigned this Feb 1, 2023
@aht007 aht007 merged commit 69ce02e into master Feb 1, 2023
@aht007 aht007 deleted the aht007/fix-upgrade-req-job branch February 1, 2023 09:49
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants