Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CumSum dnn layer #24353

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Conversation

alexlyulkov
Copy link
Contributor

@alexlyulkov alexlyulkov commented Oct 3, 2023

Fixes #20110

The algorithm had several errors, so I rewrote it.
Also the layer didn't work with non constant axis tensor. Fixed it.
Enabled CumSum layer tests from ONNX conformance.

@alexlyulkov
Copy link
Contributor Author

Fixes #20110

@alexlyulkov alexlyulkov changed the title Fixed CumSum dnn layer (algorithm and ONNX parser) WIP Fixed CumSum dnn layer (algorithm and ONNX parser) Oct 3, 2023
@alexlyulkov alexlyulkov changed the title WIP Fixed CumSum dnn layer (algorithm and ONNX parser) Fixed CumSum dnn layer Oct 3, 2023
@asmorkalov asmorkalov requested a review from dkurt October 3, 2023 05:52
@asmorkalov asmorkalov added this to the 4.9.0 milestone Oct 3, 2023
@asmorkalov asmorkalov assigned dkurt and unassigned asmorkalov Oct 3, 2023
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested manually with Ubuntu 18.04.

@asmorkalov asmorkalov merged commit 9bd14d5 into opencv:4.x Oct 3, 2023
21 of 24 checks passed
hanliutong pushed a commit to hanliutong/opencv that referenced this pull request Oct 7, 2023
Fixed CumSum dnn layer opencv#24353

Fixes opencv#20110

The algorithm had several errors, so I rewrote it.
Also the layer didn't work with non constant axis tensor. Fixed it.
Enabled CumSum layer tests from ONNX conformance.
@asmorkalov asmorkalov mentioned this pull request Oct 17, 2023
thewoz pushed a commit to thewoz/opencv that referenced this pull request Jan 4, 2024
Fixed CumSum dnn layer opencv#24353

Fixes opencv#20110

The algorithm had several errors, so I rewrote it.
Also the layer didn't work with non constant axis tensor. Fixed it.
Enabled CumSum layer tests from ONNX conformance.
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
Fixed CumSum dnn layer opencv#24353

Fixes opencv#20110

The algorithm had several errors, so I rewrote it.
Also the layer didn't work with non constant axis tensor. Fixed it.
Enabled CumSum layer tests from ONNX conformance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create layer "2840" of type "CumSum" in function 'getLayerInstance'
3 participants