Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization of run steps when using file search and mitigate .NET runtime issue when serializing ChatResponseFormat #206

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

joseharriaga
Copy link
Collaborator

@joseharriaga joseharriaga commented Sep 1, 2024

  • Fixed the deserialization of run steps when using file search. The internal representation of File Search as an IReadOnlyDictionary<string, string> is incorrect and causing issues during deserialization after the latest service. This fix changes this internal representation to IReadOnlyDictionary<string, BinaryData> instead.
  • Mitigated a .NET runtime issue that prevented ChatResponseFormat from serializing correct on targets including Unity.
  • Renamed SpeechGenerationOptions's Speed property to SpeedRatio.
  • Changed GeneratedSpeechFormat from an enum to an extensible enum.

Copy link

@Pauluz26 Pauluz26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if this can be fixed, as we are running in production application problems because we use the FileSearch a lot.

… serializing correct on targets including Unity.
@joseharriaga joseharriaga changed the title Fix deserialization of run steps when using file search Fix deserialization of run steps when using file search and mitigate .NET runtime issue when serializing ChatResponseFormat Sep 3, 2024
@joseharriaga joseharriaga merged commit cc9169a into main Sep 3, 2024
1 check passed
@joseharriaga joseharriaga deleted the joseharriaga/Fix-RunSteps branch September 3, 2024 18:14
@joseharriaga
Copy link
Collaborator Author

@Pauluz26 This fix is now live starting with version 2.0.0-beta.11:
🔗 https://www.nuget.org/packages/OpenAI/2.0.0-beta.11

Thank you!

@Pauluz26
Copy link

Pauluz26 commented Sep 4, 2024

Great! I will do some testings and update our deployments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants