Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit tests for repositories & viewmodes using turbine #2305

Closed

Conversation

PratyushSingh07
Copy link
Collaborator

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@PratyushSingh07 PratyushSingh07 changed the title fix: unit tests for repositories with turbine fix: unit tests for repositories & viewmodes using turbine Aug 25, 2023
@PratyushSingh07 PratyushSingh07 marked this pull request as ready for review August 25, 2023 22:27
@PratyushSingh07
Copy link
Collaborator Author

PratyushSingh07 commented Aug 25, 2023

I have added the below job to run the unit tests in our master yml file

  test:
    name: Unit Tests
    runs-on: ubuntu-latest
    steps:
      - name: Checking out repository
        uses: actions/checkout@v3

      - name: Test App
        run: ./gradlew test

      - name: Upload Test Report
        uses: actions/upload-artifact@v3.1.2
        if: failure()
        with:
          name: test-reports
          path: app/build/reports/

@PratyushSingh07 PratyushSingh07 marked this pull request as draft August 26, 2023 08:44
@PratyushSingh07
Copy link
Collaborator Author

I have also added job for checkstyle to ensure that it meets the code quality standards

checkstyle:
    name: Checkstyle
    runs-on: ubuntu-latest
    steps:
      - name: Checking out Repository
        uses: actions/checkout@v3

      - name: Checkstyle
        run: ./gradlew checkstyle

      - name: Upload Checkstyle Reports
        uses: actions/upload-artifact@v3.1.2
        with:
          name: checkstyle-reports
          path: app/build/reports/

@PratyushSingh07 PratyushSingh07 marked this pull request as ready for review August 26, 2023 09:18
@PratyushSingh07 PratyushSingh07 marked this pull request as draft August 27, 2023 12:07
@PratyushSingh07 PratyushSingh07 marked this pull request as ready for review August 27, 2023 14:33
@PratyushSingh07
Copy link
Collaborator Author

could you review this @jawidMuhammadi !!

@PratyushSingh07
Copy link
Collaborator Author

Any update on this @jawidMuhammadi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant