fix : migrated activities from butterknife to viewbinding #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gururani-abhishek
suggested changes
May 19, 2023
app/src/main/java/org/mifos/mobile/ui/activities/HomeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/HomeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/EditUserDetailActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/HomeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/LoginActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/LoginActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/SavingsAccountApplicationActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/HomeActivity.kt
Outdated
Show resolved
Hide resolved
PratyushSingh07
force-pushed
the
butterknife-viewBinding
branch
from
daecc08
to
d19dea6
Compare
app/src/main/java/org/mifos/mobile/ui/activities/EditUserDetailActivity.kt
Outdated
Show resolved
Hide resolved
PratyushSingh07
force-pushed
the
butterknife-viewBinding
branch
from
1df33c8
to
737ae06
Compare
PratyushSingh07
changed the title
|
Hey @jawidMuhammadi , do have a look at this PR , I have linked the issue to this PR and also changed the PR description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2142
Migrated Activities from butterknife to viewbinding as part of GSoC 23.
build.gradle file will be redundant if PR #2143 gets merged and in that case , I will remove it from this PR
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.