Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper class to capture context using ScheduledExecutorService #6712

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ammachado
Copy link

No description provided.

@ammachado ammachado requested a review from a team September 11, 2024 15:13
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (18d192d) to head (0629d79).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6712      +/-   ##
============================================
- Coverage     90.09%   90.08%   -0.02%     
- Complexity     6390     6466      +76     
============================================
  Files           711      719       +8     
  Lines         19333    19523     +190     
  Branches       1891     1922      +31     
============================================
+ Hits          17418    17587     +169     
- Misses         1335     1348      +13     
- Partials        580      588       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea. This PR needs some more testing, as there are bunch of uncovered methods in the implementation.

@ammachado ammachado requested a review from a team as a code owner September 18, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants