Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: e2e fails because not support latest bundles. #351

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Jun 30, 2023

Fixes:


In clusteradm e2e, we should depend on a stable version of bundles, otherwise any bugs or new features imported in "registration-operator", "registration", "work" or other repos, will break or block the development of clusteradm.

Recommended practice: we can make a task to "Make clusteradm support 0.12.0" when we want to release 0.12.0 binaries.

Because we can't always promise the compatibility between latest clusteradm and the latest bundles, which would exhaust us.

So any developer who uses clusteradm to deploy latest bundles should know the risk that there might be compatibility issues.

@openshift-ci openshift-ci bot requested review from itdove and ycyaoxdu June 30, 2023 16:05
@xuezhaojun
Copy link
Member Author

/assign @qiujian16

@qiujian16
Copy link
Member

qiujian16 commented Jul 3, 2023

what if we add a new feature in the latest version, and try to enable it in clusteradm? I think the root cause is we duplicate the deploy manifests in clusteradm.

@xuezhaojun
Copy link
Member Author

what if we add a new feature in the latest version, and try to enable it in clusteradm? I think the root cause is we duplicate the deploy manifests in clusteradm.

That makes sense, I can fix the inconsistent part in this PR, but finally, I think we should have a way to trigger the e2e of clusteradm when manifests of registration, work, operator changes? That would be a motivation to migrate clusteradm into ocm repo.

@xuezhaojun
Copy link
Member Author

xuezhaojun commented Jul 3, 2023

what if we add a new feature in the latest version, and try to enable it in clusteradm? I think the root cause is we duplicate the deploy manifests in clusteradm.

Another thought of this is, maybe we can release a mirror version(for example, registration-operator 0.11.1) and update the clusteradm default bundle setting in e2e.

That will decouple the development work of registraiton-operator and clusteradm. after all we promote the concept of modular.

@qiujian16
Copy link
Member

qiujian16 commented Jul 3, 2023

Yes, I think we need to some how trigger clusteradm test either periodically or per PR in ocm. But for this PR, I'd rather we do not change to default, but fix the permission issue

@xuezhaojun
Copy link
Member Author

Yes, I think we need to some how trigger clusteradm test either periodically or per PR in ocm. But for this PR, I'd rather we do not change to default, but fix the permission issue

Got it.

@xuezhaojun xuezhaojun changed the title Fix: e2e fails because not support latest bundles. WIP Fix: e2e fails because not support latest bundles. Jul 3, 2023
Signed-off-by: xuezhaojun <zxue@redhat.com>
@xuezhaojun xuezhaojun changed the title WIP Fix: e2e fails because not support latest bundles. Fix: e2e fails because not support latest bundles. Jul 3, 2023
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 3, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit d416817 into open-cluster-management-io:main Jul 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants