Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race on vertex destruction #1506

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

pavelkumbrasev
Copy link
Contributor

Description

There was a race after a reference decrement because the vertex could be destroyed by owner thread since reference counter reached zero.

Fixes # - issue number(s) if exists

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Signed-off-by: pavelkumbrasev <pavel.kumbrasev@intel.com>
@pavelkumbrasev pavelkumbrasev marked this pull request as ready for review September 5, 2024 09:28
@pavelkumbrasev pavelkumbrasev merged commit 6915673 into master Sep 5, 2024
26 checks passed
@pavelkumbrasev pavelkumbrasev deleted the dev/pavelkumbrasev/fix_race_on_task_dtor branch September 5, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants