Fix typos, UBs and warnings (ton-blockchain#625)

adnl/adnl-peer.cpp

@@ -68,7 +68,9 @@ void AdnlPeerPairImpl::alarm() {
   }
   if (retry_send_at_ && retry_send_at_.is_in_past()) {
     retry_send_at_ = td::Timestamp::never();
-    send_messages_in(std::move(pending_messages_), false);
+    auto messages = std::move(pending_messages_);
+    pending_messages_.clear();
+    send_messages_in(std::move(messages), true);
   }
   alarm_timestamp().relax(next_dht_query_at_);
   alarm_timestamp().relax(next_db_update_at_);
@@ -791,7 +793,9 @@ void AdnlPeerPairImpl::Conn::create_conn(td::actor::ActorId<AdnlPeerPairImpl> pe
 void AdnlPeerPairImpl::conn_change_state(AdnlConnectionIdShort id, bool ready) {
   if (ready) {
     if (pending_messages_.size() > 0) {
-      send_messages_in(std::move(pending_messages_), true);
+      auto messages = std::move(pending_messages_);
+      pending_messages_.clear();
+      send_messages_in(std::move(messages), true);
     }
   }
 }

crypto/block/block-db.cpp

@@ -624,6 +624,7 @@ void BlockDbImpl::get_block_by_id(ton::BlockId blk_id, bool need_data, td::Promi
       }
     }
     promise(it->second);
+    return;
   }
   promise(td::Status::Error(-666, "block not found in database"));
 }
@@ -642,6 +643,7 @@ void BlockDbImpl::get_state_by_id(ton::BlockId blk_id, bool need_data, td::Promi
       }
     }
     promise(it->second);
+    return;
   }
   if (zerostate.not_null() && blk_id == zerostate->blk.id) {
     LOG(DEBUG) << "get_state_by_id(): zerostate requested";
@@ -666,6 +668,7 @@ void BlockDbImpl::get_out_queue_info_by_id(ton::BlockId blk_id, td::Promise<td::
   if (it == state_info.end()) {
     promise(td::Status::Error(
         -666, std::string{"cannot obtain output queue info for block "} + blk_id.to_str() + " : cannot load state"));
+    return;
   }
   if (it->second->data.is_null()) {
     LOG(DEBUG) << "loading data for state " << blk_id.to_str();
@@ -679,6 +682,7 @@ void BlockDbImpl::get_out_queue_info_by_id(ton::BlockId blk_id, td::Promise<td::
   if (it2 == block_info.end()) {
     promise(td::Status::Error(-666, std::string{"cannot obtain output queue info for block "} + blk_id.to_str() +
                                         " : cannot load block description"));
+    return;
   }
   vm::StaticBagOfCellsDbLazy::Options options;
   auto res = vm::StaticBagOfCellsDbLazy::create(it->second->data.clone(), options);
@@ -707,10 +711,12 @@ void BlockDbImpl::get_out_queue_info_by_id(ton::BlockId blk_id, td::Promise<td::
   if (it->second->blk.root_hash != state_root->get_hash().bits()) {
     promise(td::Status::Error(
         -668, std::string{"state for block "} + blk_id.to_str() + " is invalid : state root hash mismatch"));
+    return;
   }
   vm::CellSlice cs = vm::load_cell_slice(state_root);
   if (!cs.have(64, 1) || cs.prefetch_ulong(32) != 0x9023afde) {
     promise(td::Status::Error(-668, std::string{"state for block "} + blk_id.to_str() + " is invalid"));
+    return;
   }
   auto out_queue_info = cs.prefetch_ref();
   promise(Ref<OutputQueueInfoDescr>{true, blk_id, it2->second->blk.root_hash.cbits(), state_root->get_hash().bits(),
@@ -758,6 +764,7 @@ void BlockDbImpl::save_new_block(ton::BlockIdExt id, td::BufferSlice data, int a
   auto save_res = save_db_file(id.file_hash, data, FMode::chk_if_exists | FMode::overwrite | FMode::chk_file_hash);
   if (save_res.is_error()) {
     promise(std::move(save_res));
+    return;
   }
   auto sz = data.size();
   auto lev = bb.alloc<log::NewBlock>(id.id, id.root_hash, id.file_hash, data.size(), authority & 0xff);
@@ -780,6 +787,7 @@ void BlockDbImpl::save_new_state(ton::BlockIdExt id, td::BufferSlice data, int a
   auto save_res = save_db_file(id.file_hash, data, FMode::chk_if_exists | FMode::overwrite | FMode::chk_file_hash);
   if (save_res.is_error()) {
     promise(std::move(save_res));
+    return;
   }
   auto sz = data.size();
   auto lev = bb.alloc<log::NewState>(id.id, id.root_hash, id.file_hash, data.size(), authority & 0xff);

crypto/fift/words.cpp

@@ -486,7 +486,7 @@ void interpret_make_pop(vm::Stack& stack) {
 }
 
 void interpret_is_string(vm::Stack& stack) {
-  stack.push_bool(stack.pop().type() == vm::StackEntry::t_string);
+  stack.push_bool(stack.pop_chk().type() == vm::StackEntry::t_string);
 }
 
 int make_utf8_char(char buffer[4], int x) {
@@ -1285,7 +1285,7 @@ void interpret_atom_anon(vm::Stack& stack) {
 }
 
 void interpret_is_atom(vm::Stack& stack) {
-  stack.push_bool(stack.pop().is_atom());
+  stack.push_bool(stack.pop_chk().is_atom());
 }
 
 bool are_eqv(vm::StackEntry x, vm::StackEntry y) {
@@ -1307,11 +1307,13 @@ bool are_eqv(vm::StackEntry x, vm::StackEntry y) {
 }
 
 void interpret_is_eqv(vm::Stack& stack) {
+  stack.check_underflow(2);
   auto y = stack.pop(), x = stack.pop();
   stack.push_bool(are_eqv(std::move(x), std::move(y)));
 }
 
 void interpret_is_eq(vm::Stack& stack) {
+  stack.check_underflow(2);
   auto y = stack.pop(), x = stack.pop();
   stack.push_bool(x == y);
 }

crypto/func/abscode.cpp

@@ -158,9 +158,9 @@ void VarDescr::set_const(td::RefInt256 value) {
   } else if (s > 0) {
     val |= _NonZero | _Pos | _Finite;
   } else if (!s) {
-    if (*int_const == 1) {
-      val |= _Bit;
-    }
+    //if (*int_const == 1) {
+    //  val |= _Bit;
+    //}
     val |= _Zero | _Neg | _Pos | _Finite | _Bool | _Bit;
   }
   if (val & _Finite) {

crypto/func/analyzer.cpp

@@ -735,7 +735,7 @@ VarDescrList Op::fwd_analyze(VarDescrList values) {
           res.emplace_back(i);
         }
         AsmOpList tmp;
-        func->compile(tmp, res, args);  // abstract interpretation of res := f (args)
+        func->compile(tmp, res, args, where);  // abstract interpretation of res := f (args)
         int j = 0;
         for (var_idx_t i : left) {
           values.add_newval(i).set_value(res[j++]);