Incorrect fnmatch due to extended glob syntax

[andychu]

Does not match the pattern with parentheses.

$ ~/git/oil/bin/osh -c 'case "foo()" in *\(\)) echo "should be match"; esac'

$ dash -c 'case "foo()" in *\(\)) echo "should be match"; esac'
should be match

Originally posted by @ko1nksm in #752 (comment)

[andychu]

Released: http://www.oilshell.org/blog/2020/05/translation-progress.html

[abathur]

When I was updating to 0.8.7, I also noticed a new test break that appears to be introduced with the tests in 61675c2 and not resolved by the fix in ee59db8. I assume, since I don't see other threads, that this is just on macOS (but haven't tried this on linux). Mainly mentioning it for searchability later :)

======================================================================
FAIL: testFnmatchExtglob (__main__.LibcTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "native/libc_test.py", line 110, in testFnmatchExtglob
    (pat, s, actual, expected))
AssertionError: Matching --@(help|verbose) against --verbose: got 0 but expected 1

----------------------------------------------------------------------

There ended up being several of these tests to patch out

[andychu]

Thanks for the report, this is actually #612 which is still open

[abathur]

Aha :)

Want me to delete the comment here and repost there? I landed here because I manually ~bisected the breaks to starting at 61675c2 and it pointed back here.