Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): remove [key: string]: any from Octokit class #309

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Mar 30, 2021

Before any property on an octokit instance could be used without complaint at build time. With this change, all additional properties on an octokit instance need to be added explicitly using plugins

@gr2m gr2m added Type: Bug Something isn't working as documented typescript Relevant to TypeScript users only labels Mar 30, 2021
@gr2m gr2m merged commit b753efb into master Mar 30, 2021
@gr2m gr2m deleted the remove-octokit-any-property branch March 30, 2021 23:51
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@octokit octokit deleted a comment Apr 1, 2021
Copy link

@amir-ghiasi amir-ghiasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ccc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented typescript Relevant to TypeScript users only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants