You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've just updated to 1.91.1 and noticed that if you resize a docked window, you won't get 3 dots after window's name. It looks like this:
Further investigation showed that the problem is in the ImGui::RenderTextEllipsis function. It calculates ellipsis size first, and it needs new FontScale property. The property must be in the draw list. But when the SetCurrentWindow function is being called, it updates FontSize this way: g.FontSize = g.DrawListSharedData.FontSize = window->CalcFontSize();
and the FontScale is being update like this: g.FontScale = g.FontSize / g.Font->FontSize;
I believe the correct version should be this: g.FontScale = g.DrawListSharedData.FontScale = g.FontSize / g.Font->FontSize;
I tested the fix and the problem went away.
The commit we are taking about was made on July 2 - 0f63d3e. I tried to find any similar issue, but I couldn't. Am I right in understanding that this is a bug and no one has noticed it yet?
P.S. Please, tell me if you need me to provide any additional info.
Version/Branch of Dear ImGui:
Version 1.91.1, Branch: docking
Back-ends:
any
Compiler, OS:
Windows 11 + MSVS 2022
Full config/build information:
No response
Details:
I've just updated to 1.91.1 and noticed that if you resize a docked window, you won't get 3 dots after window's name. It looks like this:
Further investigation showed that the problem is in the
ImGui::RenderTextEllipsis
function. It calculates ellipsis size first, and it needs newFontScale
property. The property must be in the draw list. But when theSetCurrentWindow
function is being called, it updatesFontSize
this way:g.FontSize = g.DrawListSharedData.FontSize = window->CalcFontSize();
and the
FontScale
is being update like this:g.FontScale = g.FontSize / g.Font->FontSize;
I believe the correct version should be this:
g.FontScale = g.DrawListSharedData.FontScale = g.FontSize / g.Font->FontSize;
I tested the fix and the problem went away.
The commit we are taking about was made on July 2 - 0f63d3e. I tried to find any similar issue, but I couldn't. Am I right in understanding that this is a bug and no one has noticed it yet?
P.S. Please, tell me if you need me to provide any additional info.
Screenshots/Video:
Before 0f63d3e:
After 0f63d3e:
Minimal, Complete and Verifiable Example code:
No response
The text was updated successfully, but these errors were encountered: