fix: make client clone, remove &mut self from subscribe #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #87 a user was having issues using graphql-ws-client in a multithreaded environment. These issues stemmed from: 1. As `Client::subscribe` takes `&mut self` they needed a `Arc<RwLock<Client>>`, which is a bit annoying. 2. They want to call `Client::close` at some point, which takes an owned `Client` and it's hard to get one of those when you're sharing the client among many threads. This fixes 1 by removing the mutability from `Client::subscribe` and 2 by driving `Clone` on `Client`. If a user has cloned the `Client` and they call `close` on one instance it'll close all the others. So any future calls to `Client::subscribe` on those other clients will fail. Not ideal, but I think it's reasonable to expect users to handle this case if they have a need to clone the Client.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #87 a user was having issues using graphql-ws-client in a multithreaded environment. These issues stemmed from:
Client::subscribetakes&mut selfthey needed aArc<RwLock<Client>>, which is a bit annoying.Client::closeat some point, which takes an ownedClientand it's hard to get one of those when you're sharing the client among many threads.This fixes 1 by removing the mutability from
Client::subscribeand 2 by drivingCloneonClient.If a user has cloned the
Clientand they callcloseon one instance it'll close all the others. So any future calls toClient::subscribeon those other clients will fail. Not ideal, but I think it's reasonable to expect users to handle this case if they have a need to clone the Client.