Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl debug for client #101

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

carlocorradini
Copy link
Contributor

Fix #99

@obmarg
Copy link
Owner

obmarg commented Jun 7, 2024

Thanks @carlocorradini - I have pushed a small tweak to this. I'd rather impl Debug manually so I can control what internals are exposed to users.

That's part of why I was asking what you wanted to see - I assume if you just want to be able to derive(Debug) on a struct that contains a Client this should be fine, but let me know if not.

@obmarg obmarg changed the title feat: derive debug for client feat: impl debug for client Jun 7, 2024
@carlocorradini
Copy link
Contributor Author

Awesome 😎

@obmarg obmarg merged commit 16cb857 into obmarg:main Jun 7, 2024
2 checks passed
@obmarg
Copy link
Owner

obmarg commented Jun 8, 2024

Released in v0.9.0

@carlocorradini carlocorradini deleted the client_debug branch June 8, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add derive Debug to Client
2 participants