Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] fix fish load_nvm variable interpolations #2776

Merged
merged 1 commit into from
Mar 28, 2022
Merged

[Docs] fix fish load_nvm variable interpolations #2776

merged 1 commit into from
Mar 28, 2022

Conversation

legendecas
Copy link
Contributor

Variables in test arguments must be interpolated, or the test always fails and leading to reloading of nvm, which is way slower.

ljharb
ljharb approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ljharb ljharb merged commit c367d7d into nvm-sh:master Mar 28, 2022
@legendecas legendecas deleted the fix-fish branch March 28, 2022 16:07
@Joecliff8 Joecliff8 linked an issue May 15, 2022 that may be closed by this pull request
[spam] #2813
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
informational
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[spam]
2 participants
@legendecas @ljharb