Fix nvm unload fast test cleanup
#2332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Oct 22, 2020
| @@ -5,7 +5,7 @@ set -ex | |||
| BEFORE="./before.tmp" | |||
| AFTER="./after.tmp" | |||
|
|
|||
| cleanup () { echo rm -f "${BEFORE}" "${AFTER}"; } | |||
| cleanup () { rm -f "${BEFORE}" "${AFTER}"; } | |||
There was a problem hiding this comment.
ha, no this was just me debugging locally and forgetting to remove my echo. good catch.
This comment has been minimized.
This comment has been minimized.
|
oops! |
|
As soon as tests are passing on master, I'll land this directly. |
ljharb
added
hacktoberfest-accepted
|
Landed as f2c5ce4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that
./test/fast/Running "nvm unload" should unset all function and variables.would leave behind./before.tmpand./after.tmpfiles and clutter thegit status. This fixes the cleanup behavior.Let me know if it'd be preferable to move the temporary files into a
test/**/test_outputfolder which is covered by.gitignore, or something like that.