Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Remove ppa source since we migrated to Ubuntu Trusty #1470

Merged
merged 1 commit into from
Apr 2, 2017

Conversation

PeterDaveHello
Copy link
Collaborator

Though we can't drop add-on but Ubuntu 14.04 doesn't need to install gcc & g++ v4.8 from a ppa, remove them can speed up the build.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I was asking about in #1458 (review) :-p

@ljharb ljharb added the testing Stuff related to testing nvm itself. label Apr 2, 2017
@ljharb ljharb merged commit 18df8e3 into nvm-sh:master Apr 2, 2017
@PeterDaveHello PeterDaveHello deleted the travis-ci-ppa branch April 2, 2017 03:31
@PeterDaveHello
Copy link
Collaborator Author

@ljharb I thought you was asking for "addons" ha ...

@PeterDaveHello
Copy link
Collaborator Author

PeterDaveHello commented Apr 2, 2017

Since gcc and g++ v4.8 are both installed already on Travis CI's Ubuntu 14.04 environment, this change now makes the CI super faster!

@PeterDaveHello
Copy link
Collaborator Author

@ljharb if it'll be good for you, I even want to remove them in the package list so that apt won't need to calculate their dependency, what do you think?

@ljharb
Copy link
Member

ljharb commented Apr 2, 2017

Maybe let's just comment them out; probably good to keep them for documentation purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Stuff related to testing nvm itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants