Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Telescope live_grep on Git root #492

Merged
merged 2 commits into from
Nov 6, 2023
Merged

add Telescope live_grep on Git root #492

merged 2 commits into from
Nov 6, 2023

Conversation

slara
Copy link
Contributor

@slara slara commented Nov 6, 2023

Adds a keymap to use Live Search with Grep on the entire current git project.

@feoh
Copy link
Collaborator

feoh commented Nov 6, 2023

This looks neat! Thank you for your contribution.

Has it been tested on Windows?

If not and you don't have access to a Windows install I can test it in my fork.

@slara
Copy link
Contributor Author

slara commented Nov 6, 2023

Hi @feoh , Thanks! I tested it on Linux and Mac. I don't have a Windows install available.

@dam9000
Copy link
Contributor

dam9000 commented Nov 6, 2023

Can we keep the old <leader>sg keymap as it was (live grep) and use your newly added new <leader>sG for the new functionality (grep git root), this would be less disruptive for existing users.

@feoh
Copy link
Collaborator

feoh commented Nov 6, 2023

I love this idea!

@dam9000
Copy link
Contributor

dam9000 commented Nov 6, 2023

Hmm, another thing to consider, perhaps this functionality should be made into a plugin that can then be added to kickstart as a single line addition, if we want to keep the "kickstart": small, single file, and easy to learn. Wouldn't that be a better approach?

@feoh
Copy link
Collaborator

feoh commented Nov 6, 2023

@dam9000 Gonna pump the brakes on that one :) I don't want to get kickstart.nvim into the business of needing to support plugins meant to extend it rather than Neovim itself.

I don't personally think this code change is so massive, I think it's a decision of include it or don't. I'm personally leaning towards including it but I'm open to other feedback.

@feoh
Copy link
Collaborator

feoh commented Nov 6, 2023

I don't really understand how to use the :Git stuff yet, and when I try this here on Windows I get "Buffer not associated with file" so I'd guess that's working as designed?

Man I wish I had the time to delve more deeply into this stuff :)

I'm going to merge and if any ninjas out there understand enough to tell me it's wrong we can work on it from there :)

@feoh feoh merged commit bced1c2 into nvim-lua:master Nov 6, 2023
@slara
Copy link
Contributor Author

slara commented Nov 6, 2023

Thanks @feoh! This is so cool!

I think this could happen if you are inside a special buffer like NeoTree or the dashboard. I will try to reproduce it and make a fix.

qiuye2015 pushed a commit to qiuye2015/fjp.nvim that referenced this pull request Dec 10, 2023
add Telescope live_grep on Git root
antoson pushed a commit to antoson/kickstart.nvim that referenced this pull request Dec 16, 2023
add Telescope live_grep on Git root
cbmorrell pushed a commit to cbmorrell/kickstart-modular.nvim that referenced this pull request Apr 22, 2024
add Telescope live_grep on Git root
s-frick pushed a commit to s-frick/kickstart.nvim that referenced this pull request Jul 29, 2024
add Telescope live_grep on Git root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants