treesitter: ensure 'javascript' installed along with typescript and tsx #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parser is actually needed for some *JSX* parsing, and since typescript and tsx are already getting installed, it makes sense to also install the javascript parser.
qiuye2015
pushed a commit
to qiuye2015/fjp.nvim
that referenced
this pull request
Dec 10, 2023
treesitter: ensure 'javascript' installed along with typescript and tsx
s-frick
pushed a commit
to s-frick/kickstart.nvim
that referenced
this pull request
Jul 29, 2024
treesitter: ensure 'javascript' installed along with typescript and tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parser is actually needed for some JSX parsing, and since typescript and tsx are already getting installed, it makes sense to also install the javascript parser.
I actually spent three days trying to figure out why my JSX wasn't being parsed and highlighted and it was because of this.
The three days of course is also because I'm a neovim noob trying to modernize my tools after years of vim+ctags. I had to first understand that some of the highlighting is done by
tsserverLSP. Then I had to learn what tree-sitter is. Eventually I tried to run:InspectTreeto clearly see that it is complaining about a missing parser. And here we are.👏The situation is made more difficult given the plethora of treesitter highlighting bug reports for neovim in the recent past, which were all irrelevant to my problem and mostly already resolved because the treesitter neovim integreation has moved so fast over the past couple of years!
This is all to say: this project aims to minimize noob pain (and it mostly succeeds, thank you!), and including the javascript treesitter parser might help alleviate a lot of noob pain.