Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindings: Query incoming blocks of a phi instruction #973

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

tbennun
Copy link
Contributor

@tbennun tbennun commented Aug 5, 2023

When iterating over the operands of a phi instruction, the incoming basic blocks are missing and cannot be queried by any means. This PR adds them to the bindings.

@gmarkall
Copy link
Member

gmarkall commented Aug 7, 2023

Many thanks for the PR - I'll mark as ready for review.

@gmarkall gmarkall self-requested a review August 8, 2023 14:25
@gmarkall gmarkall added this to the v0.42.0-rc1 milestone Aug 8, 2023
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esc esc merged commit 06fb732 into numba:main Sep 28, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants