fix: back button icon rendering inconsistently #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the operating system and therefore the system font the back icon being a unicode arrow means it'll render inconsistently, sometimes I've seen it looking really odd. Instead make use of the font awesome arrow so that'll it render consistently no matter ths system font.
nolanlawson
reviewed
Dec 10, 2022
nolanlawson
reviewed
Dec 10, 2022
| display: inline-flex; | ||
| align-items: center; | ||
| justify-self: flex-end; | ||
| font-size: 1.2857142857142858em; |
There was a problem hiding this comment.
Was this font-size generated by a tool or something? Same question about the 0.6666666 below. 🙂
There was a problem hiding this comment.
To get the alignment on a pixel grid I chose to calculate this so it rounds to the nearest pixel.
nolanlawson
approved these changes
Dec 10, 2022
alice-werefox
pushed a commit
to alice-werefox/sema-werefox-cafe
that referenced
this pull request
Apr 3, 2023
Depending on the operating system and therefore the system font the back icon being a unicode arrow means it'll render inconsistently, sometimes I've seen it looking really odd. Instead make use of the font awesome arrow so that'll it render consistently no matter ths system font.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the operating system and therefore the system font the back icon being a unicode arrow means it'll render inconsistently, sometimes I've seen it looking really odd.
Instead make use of the font awesome arrow so that'll it render consistently no matter the system font.